-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Project.toml for new Julia Registrator package flow #1277
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1277 +/- ##
==========================================
- Coverage 90.08% 85.83% -4.25%
==========================================
Files 36 36
Lines 3953 4159 +206
==========================================
+ Hits 3561 3570 +9
- Misses 392 589 +197
Continue to review full report at Codecov.
|
are we supposed to delete REQUIRE too? isn't there supposed to be a version number in Project.toml? cf 1, 2, 3, 4, 5 |
|
The other thing we should talk about if whether we want to start [compat]
Colors = "0.3.4, 0.4, 0.5, 0.6, 0.7, 0.8, 0.9" |
there are new features, not just bug fixes, so let's go with 1.1. should add test/Project.toml too and delete test/REQUIRE version pinning seem reasonable. this script might do that. would be good to compare it's output with yours anyway. |
That script generated a file identical to mine with the exception that cd("Gadfly.jl")
import Pkg
Pkg.activate(".")
Pkg.instantiate()
Pkg.test() |
I've moved test/REQUIRE into the Project.toml file under |
looks great. two things: could you please squash your first two commits so as not to clutter the git log. your uuid for Statistics matches mine and the one in the julia stdlib. would be good though to get a firm answer on why @StefanKarpinski 's script is returning a different one. perhaps submit an issue to Pkg.jl? |
Done. |
Since packages new register directly to the General repo, a
Project.toml
will be needed before Gadfly's next release.