Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing broken on 0.7 #1328

Closed
tlnagy opened this issue Oct 9, 2019 · 2 comments · Fixed by #1332
Closed

Testing broken on 0.7 #1328

tlnagy opened this issue Oct 9, 2019 · 2 comments · Fixed by #1332

Comments

@tlnagy
Copy link
Member

tlnagy commented Oct 9, 2019

Continuing the discussion from #1318, cc @Mattriks

I had a bit more time to look into this and it looks like we initially install Parsers v0.3.0 (https://travis-ci.org/GiovineItalia/Gadfly.jl/jobs/594389463#L217), but then install Parsers v0.2.22 https://travis-ci.org/GiovineItalia/Gadfly.jl/jobs/594389463#L456 when actually doing the testing?

But AFAICT JSON.jl stays on v0.21 https://travis-ci.org/GiovineItalia/Gadfly.jl/jobs/594389463#L305, which is the version that introduces the requirement on Parsers. So likely what is happening is that Parsers is downgraded after Compose is installed and that causes the build failure. The solution is probably to install Compose#master again in the test environment to force dependency resolution.

@tlnagy
Copy link
Member Author

tlnagy commented Oct 14, 2019

@bjarthur are you okay with sunsetting 0.7 support?

@bjarthur
Copy link
Member

i'm fine with dropping 0.7 support. it's been over a year now. but only because so many of our dependencies are dropping it. unnecessary for them to do so because the only difference with 1.0 is the removal of deprecation warnings. i'll submit PRs to Compose and Gadfly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants