Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gadfly doesn't show plots in julia-vscode plot pane. #1311

Closed
synxroform opened this issue Sep 8, 2019 · 5 comments · Fixed by #1373
Closed

Gadfly doesn't show plots in julia-vscode plot pane. #1311

synxroform opened this issue Sep 8, 2019 · 5 comments · Fixed by #1373

Comments

@synxroform
Copy link

I don't think it is Gadfly isuue, but the guy at julia-vscode say it is. Look at this thread.

@tlnagy
Copy link
Member

tlnagy commented Sep 10, 2019

Hey @bjarthur or @MikeInnes, any thoughts on this? I don't much experience with the Juno/display stack code.

@Mattriks
Copy link
Member

The issue also occurs with Plots (julia-vscode/julia-vscode#819). For Gadfly, the GadflyDisplay was introduced for the reasons here.

@Mattriks
Copy link
Member

When using vscode try:

using Gadfly
popdisplay()

@davidanthoff
Copy link

I think if the package really needs to push something onto the display stack, it should follow the Plots.jl pattern and make sure it doesn't end up being on top of the stack:

https://github.com/JuliaPlots/Plots.jl/blob/172193e70690c8c72996fb32ea4b3e235e0b72f0/src/init.jl#L22

That is probably the most compatible way to do this right now.

The current implementation breaks both VS Code and ElectronDisplay.jl, whereas the Plots.jl way of handling this works with both (and presumably also Juno).

@davidanthoff
Copy link

Great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants