Docs aren't getting deployed?

[tlnagy]

@bjarthur any ideas on why Travis is skipping doc deployment? https://travis-ci.org/GiovineItalia/Gadfly.jl/jobs/476704204

Documenter: populating indices.
Documenter: rendering document.
Documenter: skipping docs deployment.

[bjarthur]

not sure why it didn't work this time, but it did last time: https://travis-ci.org/GiovineItalia/Gadfly.jl/builds/475180576?utm_source=github_status&utm_medium=notification

[tlnagy]

It looks like it skips in your link too:

Documenter: setting up build directory.
Documenter: expanding markdown templates.
Documenter: building cross-references.
Documenter: running document checks.
 > checking for missing docstrings.
 > running doctests.
 > checking footnote links.
Documenter: populating indices.
Documenter: rendering document.
Documenter: skipping docs deployment.
Documenter: You can set DOCUMENTER_DEBUG to "true" in Travis to see more information.

[bjarthur]

https://github.com/GiovineItalia/Gadfly.jl/blob/master/.travis.yml#L34

[tlnagy]

http://gadflyjl.org/dev/ is out of date as well because there are some bugs in the plots that have been fixed on master, e.g. opacity in the Geom.ribbon is broken in the docs, but the exact same code works on master. This was fixed at some point after 1.0.1, I think in #1231

[tlnagy]

Line L34 in .travis.yml refers to after the docs have been deployed. Deployment should not be skipped. You can verify that at your first link:

Documenter: skipping docs deployment.
Documenter: You can set DOCUMENTER_DEBUG to "true" in Travis to see more information.
...
Skipping the after_success step, as specified in the configuration.

[bjarthur]

cc @mortenpi can you please help with a travis doc deployment question?

[tlnagy]

I've started up the VM with the DOCUMENTER_DEBUG key set to true. Hopefully that'll give us a better idea of what is going on: https://travis-ci.org/GiovineItalia/Gadfly.jl/jobs/476704204

[mortenpi]

The build linked in the OP looks like a PR build for #1240, right? The PR builds are not supposed to deploy docs (among other reasons, they don't have access to DOCUMENTER_KEY).

The last build for the master branch deployed fine as far as I can tell: https://travis-ci.org/GiovineItalia/Gadfly.jl/builds/475701320

[tlnagy]

Ah, good catch. My bad. I wonder why the plots are broken in the documentation, but build fine locally on master. That's a separate problem and I'll open a separate issue for that.

[mortenpi]

Regarding plots, I didn't look into it, but could it be something similar to JuliaDocs/Documenter.jl#921?