Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade angular-bootstrap dependency version #173

Closed
ctamisier opened this issue Jan 17, 2017 · 3 comments
Closed

upgrade angular-bootstrap dependency version #173

ctamisier opened this issue Jan 17, 2017 · 3 comments

Comments

@ctamisier
Copy link

Would it be safe to update the angular-bootstrap dependency to '>1.2.0' in bower.json ?
"dependencies": {
"angular-bootstrap": "^1.2.0"
}

I tested some components with angular-bootstrap 2.4.0 and it seems ok...
There were breaking changes in version 2.0.0 but like in any new versions.

@Gillardo
Copy link
Owner

If the library doesnt work with angular-bootstrap 2.0, then cant really update the bower.json to accept that

@ctamisier
Copy link
Author

It seems to work with angular-bootstrap 2.0.0.

When I say "There were breaking changes in version 2.0.0", I meant between angular-bootstrap 1.3.3 and angular-bootstrap 2.0.0.

I was trying to find the reason to increase the major version in angular-bootstrap (why 1.3.3 to 2.0.0).

In the changelog: https://github.com/angular-ui/bootstrap/blob/master/CHANGELOG.md,
Does the switch from 1.3.3 to 2.0.0 will break bootstrap-ui-datetime-picker ? (I don't think but I don't know enough those tools).

I just want to use the last version of angular-bootstrap (2.4.0) and bootstrap-ui-datetime-picker (2.5.2) if they are compatible. (because I think there is no reason that they're not... but that's just a guess).

I will try to confirm that..

@Gillardo
Copy link
Owner

If you can confirm it all works fine with 2.0.0 i will happily increase the dependency

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants