Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type hint using stub file instead of inline comments #53

Open
GhostofGoes opened this issue Dec 5, 2019 · 0 comments
Open

Type hint using stub file instead of inline comments #53

GhostofGoes opened this issue Dec 5, 2019 · 0 comments
Labels
feature New feature (or addition of new functionality to existing feature) good first issue help wanted
Milestone
Stable Release (1.0)

Comments

@GhostofGoes
Copy link
Owner

Move to using a *.pyi stub file for type hints instead of the current inline comments. There are a number of reasons I'd like to do this:

  • Ability to use complex types without adding more imports, as well as recent language features like forward references and TypedDict on a codebase that presently still supports 2.7
  • Readability: type comments don't look great and clutter the already ugly (in my opinion) code base
  • Performance: avoid attempting to import the typing module
@GhostofGoes GhostofGoes added this to the Stable Release (1.0) milestone Dec 5, 2019
@GhostofGoes GhostofGoes added the feature New feature (or addition of new functionality to existing feature) label Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature New feature (or addition of new functionality to existing feature) good first issue help wanted
Projects
None yet
Milestone
Stable Release (1.0)
Development

No branches or pull requests
1 participant
@GhostofGoes