Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vg auto-activate works incorrectly #45

Open
ssergiienko opened this issue Nov 19, 2018 · 0 comments
Open

vg auto-activate works incorrectly #45

ssergiienko opened this issue Nov 19, 2018 · 0 comments

Comments

@ssergiienko
Copy link

ssergiienko commented Nov 19, 2018

Case 1: Destroyed environments are re-created again with cd

[host]xyz_proj$ vg init
...
(xyz_proj) [host]xyz_proj$ vg destroy
[host]xyz_proj$ cd any_other_folder
[host]any_other_folder$ cd xyz_proj
Creating workspace "xyz_proj" with global fallback import mode
Activating "xyz_proj"
(xyz_proj) [host]xyz_proj$

I've managed to fix the problem with new condition to activate function:

__vg_auto_activate() {
    activation_root=$PWD
    while [ "$activation_root" != "" ]; do
        if [ -f "$activation_root/.virtualgo" ]; then
            new_virtualgo_name=$(cat "$activation_root/.virtualgo")
            if [ "" = "$VIRTUALGO" ] || [ "$new_virtualgo_name" != "$VIRTUALGO" ]; then
                # that's what I added
                if [[ -d "$HOME/.virtualgo/$new_virtualgo_name" ]];then   # <=========
                vg activate "$new_virtualgo_name"
                fi
            fi
            return

Also, I think that vg destroy should do vg unlink automatically

Case 2: Activate in child folder of folder that is linked to some vg environment will create new environment instead of activating parent.

src is a child folder of goenv:

(goenv) [host]src$ vg deactivate
Deactivating goenv
[host]src$ vg activate
Creating workspace "src" with global fallback import mode
Activating src
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant