Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Internal] Move Old SDK tests to 13 - Currently disabled #2262

Merged
merged 3 commits into from
Aug 31, 2022
Merged

[Internal] Move Old SDK tests to 13 - Currently disabled #2262

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
384d1e4
Move 'old SDK' regression to 13
polqf Aug 31, 2022
f89f6fb
Disable Xcode 13 regression until Xcode 14 is used
polqf Aug 31, 2022
be04261
Merge branch 'develop' into bugfix/xcode12-ci
polqf Aug 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 23 additions & 21 deletions .github/workflows/smoke-checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,27 +164,29 @@ jobs:
run: echo "::set-output name=launch_id::${{env.LAUNCH_ID}}"
if: env.LAUNCH_ID != ''

build-xcode12:
name: Build LLC + UI (Xcode 12)
runs-on: macos-11
if: ${{ github.event_name != 'push' }}
steps:
- uses: actions/checkout@v2
- uses: ./.github/actions/bootstrap
- name: Build LLC (Xcode 12)
run: bundle exec fastlane test device:"iPhone 12" build_for_testing:true
timeout-minutes: 25
env:
XCODE_VERSION: "12.5.1"
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
GITHUB_EVENT: ${{ toJson(github.event) }}
- name: Build UI (Xcode 12)
run: bundle exec fastlane test_ui device:"iPhone 12" build_for_testing:true
timeout-minutes: 25
env:
XCODE_VERSION: "12.5.1"
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
GITHUB_EVENT: ${{ toJson(github.event) }}
# build-xcode13:
# name: Build LLC + UI (Xcode 13)
# runs-on: macos-12
# if: ${{ github.event_name != 'push' }}
# steps:
# - uses: actions/checkout@v2
# - uses: ./.github/actions/bootstrap
# - name: List Xcode versions xcversion sees
# run: mdfind "kMDItemCFBundleIdentifier = 'com.apple.dt.Xcode'"
# - name: Build LLC (Xcode 13)
# run: bundle exec fastlane test device:"iPhone 13" build_for_testing:true
# timeout-minutes: 25
# env:
# XCODE_VERSION: "13"
# GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
# GITHUB_EVENT: ${{ toJson(github.event) }}
# - name: Build UI (Xcode 13)
# run: bundle exec fastlane test_ui device:"iPhone 13" build_for_testing:true
# timeout-minutes: 25
# env:
# XCODE_VERSION: "13"
# GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
# GITHUB_EVENT: ${{ toJson(github.event) }}

build-apps:
name: Build Sample + Demo Apps
Expand Down
8 changes: 4 additions & 4 deletions Tests/StreamChatTests/Controllers/ChannelController/ChannelController_Tests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2170,8 +2170,8 @@ final class ChannelController_Tests: XCTestCase {

waitForExpectations(timeout: 0.1)

let paginatonParameter = env.channelUpdater?.update_channelQuery?.pagination?.parameter
guard case let .lessThan(paginationMessageId) = paginatonParameter else {
let paginationParameter = env.channelUpdater?.update_channelQuery?.pagination?.parameter
guard case let .lessThan(paginationMessageId) = paginationParameter else {
XCTFail("Missing pagination parameter")
return
}
Expand Down Expand Up @@ -2212,8 +2212,8 @@ final class ChannelController_Tests: XCTestCase {

waitForExpectations(timeout: 0.1)

let paginatonParameter = env.channelUpdater?.update_channelQuery?.pagination?.parameter
guard case let .lessThan(paginationMessageId) = paginatonParameter else {
let paginationParameter = env.channelUpdater?.update_channelQuery?.pagination?.parameter
guard case let .lessThan(paginationMessageId) = paginationParameter else {
XCTFail("Missing pagination parameter")
return
}
Expand Down