Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match view description to menu description #4248

Merged
merged 2 commits into from
Aug 6, 2024

Conversation

janette
Copy link
Member

@janette janette commented Aug 5, 2024

fixes [#4210]

QA Steps

  • ddev dkan-site-install
  • ddev drush uli
  • Confirm no change to the DKAN menu

@dmundra dmundra self-requested a review August 6, 2024 16:13
Copy link
Contributor

@dmundra dmundra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@janette this change makes the view description match https://github.com/GetDKAN/dkan/blob/2.x/modules/metastore/metastore.links.menu.yml#L34 but the ticket #4210 was asking to change the menu link to match the view description 'Administer all content in the DKAN metastore'. Wouldn't that be better?

Copy link
Contributor

@dmundra dmundra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great and thank you for making the items consistent.

@dmundra dmundra merged commit 3f8e454 into 2.x Aug 6, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants