Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the event time (On Tick and Off Tick) available in Break MidiEvent #27

Open
Ecnassianer opened this issue Mar 27, 2021 · 0 comments

Comments

@Ecnassianer
Copy link

Ecnassianer commented Mar 27, 2021

The Time variable in OnMidiEvent seems to give the current playback time when the game thread processes the midi event, not the time recorded in the midi file and associated with the event itself. The resulting value is framerate dependent. This makes it difficult to respond to notes in a specific time range, since you don't know how the Time variable corresponds to the note's normally recorded time.

Additionally, the value of Time doesn't scale with Playback Speed, so the Time can be wildly different than the recorded time in the midi file.

If the "current playback time" behavior of Time isn't a bug, please expose the recorded time of the event in Break MidiEvent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant