You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
PR #347 introduced a crucial bug fix to correct the way unit conversion is applied. However, these changes introduced test fails in the test_mpi_vs_multiprocess_vs_single_process module.
The tests were failing in the tests.common.assert_tifs_equal function. Some were failing when CVD_MAXVAR and/or CVD_ALPHA were not equivalent to 1.d.p. between mpi/multiprocess/serial jobs:
To bring the unit conversion bug fix in to master ASAP, the test fail problem was bypassed in commit 0a5363e by switching these tests to use the old unit test data (gamma_conf) rather than the new Mexico "CropA" data (mexico_cropa_conf).
The reasons for the test fails using Mexico CropA data should be fully investigated and rectified.
The text was updated successfully, but these errors were encountered:
PR #347 introduced a crucial bug fix to correct the way unit conversion is applied. However, these changes introduced test fails in the
test_mpi_vs_multiprocess_vs_single_process
module.The tests were failing in the
tests.common.assert_tifs_equal
function. Some were failing when CVD_MAXVAR and/or CVD_ALPHA were not equivalent to 1.d.p. between mpi/multiprocess/serial jobs:PyRate/tests/common.py
Line 196 in 8893509
PyRate/tests/common.py
Line 203 in 8893509
To bring the unit conversion bug fix in to
master
ASAP, the test fail problem was bypassed in commit 0a5363e by switching these tests to use the old unit test data (gamma_conf) rather than the new Mexico "CropA" data (mexico_cropa_conf).The reasons for the test fails using Mexico CropA data should be fully investigated and rectified.
The text was updated successfully, but these errors were encountered: