Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_get_kriging_matrix is very long for large datasets #68

Closed
alexisrosuel opened this issue Jul 3, 2017 · 5 comments
Closed

_get_kriging_matrix is very long for large datasets #68

alexisrosuel opened this issue Jul 3, 2017 · 5 comments
Assignees
Milestone

Comments

@alexisrosuel
Copy link

Hi again,

I just saw that the function '_get_kriging_matrix' is very very long (about 5-10 secs) when the training points size is about 10,000 or 15,000.

Do you know if a speed up would be possible ? For instance, I was thinking that as I specified in my model 'n_closed_points' = 100, computing the kriging matrix over the 100 nearest points would be sufficient ?

@rth
Copy link
Contributor

rth commented Jul 4, 2017

@alexisrosuel The bottleneck must be in the cdist and variogram calculations in _get_kriging_matrix .

Would this issue be related to a local variogram model discussed in #41?

@alexisrosuel
Copy link
Author

Yes indeed, I was not sure yesterday, but it is clear now that this is the same issue

@basaks
Copy link
Collaborator

basaks commented Jul 4, 2017

@rth Yes, very much so. A local variogram model could help in this situation.
I am still looking to get some funding for that work.

@MuellerSeb
Copy link
Member

I would say the problem is, that even with n_closest_points given, the whole matrix is constructed. This should be only done for the points needed.

@MuellerSeb MuellerSeb self-assigned this Jan 28, 2020
@MuellerSeb MuellerSeb added this to the v2.0 milestone Jan 28, 2020
@MuellerSeb
Copy link
Member

This should be discussed in #143. Closing for now. Feel free to re-open or go on with discussion in the linked issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants