add zmap io and no_data param in write_asc #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MuellerSeb
requested changes
Jun 19, 2021
There was a problem hiding this comment.
Thank you for this contribution!
Some requests from my side:
- I'd love to see the bug mentioned in BUG: write_asc_grid function does not run as expected #197 fixed with this contribution (since the same would apply to your additions)
- see review comments
- please run
black .in the root directory to format the code accordingly (CI is failing there)
Edit:
- please add a test like for the asc routines:
Line 1127 in 09fe018
This was
linked to
issues
Jun 19, 2021
Closed
MuellerSeb
approved these changes
Jun 22, 2021
There was a problem hiding this comment.
@MarkTNO thanks for the additions. I applied black and pushed to your branch (don't forget to pull if you want to add further changes).
If you think, this is ready, let me know. Then I am happy to merge.
|
This looks good. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example zmap:
https://saurabhkukade.com/posts/2020/07/understanding-zmap-file-format/