We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PyKrige/pykrige/compat.py
Line 14 in 1a889a7
This line is not working with the newest version of sklearn, resulting in a missing mean_train_score.
mean_train_score
I think, this is because they implemented keyword-only arguments there: https://github.com/scikit-learn/scikit-learn/blob/fd237278e895b42abe8d8d09105cbb82dc2cbba7/sklearn/model_selection/_search.py#L1174
The text was updated successfully, but these errors were encountered:
Yes, we should switch to inspect.signature,
inspect.signature
>>> from sklearn.model_selection import GridSearchCV >>> import inspect >>> est_sign = inspect.signature(GridSearchCV) >>> 'return_train_score' in est_sign.parameters True
Sorry, something went wrong.
@rth: Cool! Could you come up with a PR?
MuellerSeb
Successfully merging a pull request may close this issue.
PyKrige/pykrige/compat.py
Line 14 in 1a889a7
This line is not working with the newest version of sklearn, resulting in a missing
mean_train_score
.I think, this is because they implemented keyword-only arguments there:
https://github.com/scikit-learn/scikit-learn/blob/fd237278e895b42abe8d8d09105cbb82dc2cbba7/sklearn/model_selection/_search.py#L1174
The text was updated successfully, but these errors were encountered: