-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python 3 support #10
Comments
This is very true. I've been thinking about this over the past few weeks, and I think I'll finally have some time to actually work on this coming up. Clearly, the print statements will need to be changed, but that should just be a matter of putting parentheses around all the things to be printed (apparently this works in both Python 2 and Python 3, which I didn't know). I haven't really used Python 3, so do you have any thoughts on anything else that could clearly go wrong? |
I don't think there would be that many changes to make the code base compatible with both Python 2.7 and 3.x (see this cheat sheet ). First thing could be to add,
at the top of every The only real issue I see is that the Cython BLAS binding I did won't work with 3.x as far as I remember. So the solution is either to try fixing that, or ask for |
Alright, I've updated the code so that it should be Python 3 compatible. (The new version is also on PyPI.) The tests on TravisCI and AppVeyor are passing with when run with the Python 2.7 and Python 3.4 platforms. I've also updated the setup script to try to better address the Cython compiler issue with Windows (as discussed in issue #8). Now the script attempts to build the Cython extensions regardless of operating system or build_ext compiler settings, and if the build fails it falls back to a pure Python implementation without building the Cython extensions. (I followed the example set here.) Also, the setup script currently does not build the Cython extensions for Python 3. This can be easily changed in the future. One thing that I am slightly concerned about is the way I'm currently using strings in the setup script. I couldn't use the little |
Awesome! This works really well. About the unicode in |
In the long term perspective, it would probably be good to add Python 3.x support alongside 2.7.
The corresponding test environments, could then be uncommented in
.travis.yml
andappveyor.yml
...The text was updated successfully, but these errors were encountered: