Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in Zinn&Harvey transformation #71

Closed
MuellerSeb opened this issue Feb 21, 2020 · 1 comment
Closed

Bug in Zinn&Harvey transformation #71

MuellerSeb opened this issue Feb 21, 2020 · 1 comment
Assignees
@MuellerSeb
Labels
bug Something isn't working
Milestone
1.2

Comments

@MuellerSeb
Copy link
Member

MuellerSeb commented Feb 21, 2020 •
edited
Loading

GSTools/gstools/transform/field.py

Line 272 in 7001713

field = np.abs((field - mean) / var)

GSTools/gstools/transform/field.py

Line 277 in 7001713

return field * var + mean

the standard-deviation np.sqrt(var) should be used here, not the variance var.

This is related to #70
@MuellerSeb MuellerSeb added the bug Something isn't working label Feb 21, 2020
@MuellerSeb MuellerSeb added this to the 1.2 milestone Feb 21, 2020
@MuellerSeb MuellerSeb self-assigned this Feb 21, 2020
@MuellerSeb
Copy link
Member Author

Closed with #70

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MuellerSeb MuellerSeb

Labels
bug Something isn't working
Projects
None yet
Milestone
1.2
Development

No branches or pull requests
1 participant
@MuellerSeb