Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dropping Python 2.7 and 3.4 support #40

Closed
MuellerSeb opened this issue Nov 7, 2019 · 6 comments
Closed

Dropping Python 2.7 and 3.4 support #40

MuellerSeb opened this issue Nov 7, 2019 · 6 comments
Assignees
@MuellerSeb @LSchueler
Labels
enhancement New feature or request FutureWarning Aim is to prevent FutureWarnings when they appear. Refactoring Code-Refactoring needed here
Milestone
1.2

Comments

@MuellerSeb
Copy link
Member

Since Python 2 will reach it's EOL on 1. Jan 2020, we will drop support for it, too.

The next minor release (v1.2) will then be Python 3 only.

Since TravisCI supports Windows but only for Python 3 we can then drop the use of Appveyor and stick to one CI system.
@MuellerSeb MuellerSeb added enhancement New feature or request FutureWarning Aim is to prevent FutureWarnings when they appear. Refactoring Code-Refactoring needed here labels Nov 7, 2019
@MuellerSeb MuellerSeb added this to the 1.2 milestone Nov 7, 2019
@MuellerSeb
Copy link
Member Author

See here: python3statement/python3statement.github.io#272

@LSchueler
Copy link
Member

Python 3.4 has already reached its EOL on 2019-03-18.

We should drop the support of that version too.

@LSchueler LSchueler changed the title Dropping Python 2 support Dropping Python 2.7 and 3.4 support Nov 7, 2019
@MuellerSeb
Copy link
Member Author

Now we have to fulfill our promise:
https://python3statement.org/
😊

@LSchueler LSchueler mentioned this issue Nov 8, 2019
Merged
@MuellerSeb
Copy link
Member Author

We should add this line in setup.py:

python_requires='>=3.5',

See here:
https://packaging.python.org/guides/distributing-packages-using-setuptools/#python-requires

@LSchueler LSchueler mentioned this issue Nov 18, 2019
Merged
@LSchueler
Copy link
Member

LSchueler commented Nov 18, 2019 •
edited
Loading

Note for self:
remove "Python 2" classifier from setup.py too when dropping support.

@MuellerSeb
Copy link
Member Author

Done with #43

@MuellerSeb MuellerSeb mentioned this issue Mar 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MuellerSeb MuellerSeb

@LSchueler LSchueler

Labels
enhancement New feature or request FutureWarning Aim is to prevent FutureWarnings when they appear. Refactoring Code-Refactoring needed here
Projects
None yet
Milestone
1.2
Development

No branches or pull requests
2 participants
@MuellerSeb @LSchueler