Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cython: conditional compilation deprecated #343

Closed
MuellerSeb opened this issue Apr 8, 2024 · 3 comments
Closed

Cython: conditional compilation deprecated #343

MuellerSeb opened this issue Apr 8, 2024 · 3 comments
Assignees
@LSchueler
Milestone
1.6

Comments

@MuellerSeb
Copy link
Member

cython/cython#4310

The conditional compilation introduced in #336 are deprecated by cython.
I capped the cython version in #340 for now.

@LSchueler this should be cleaned up at some point.
@MuellerSeb MuellerSeb added this to the 1.6 milestone Apr 8, 2024
@MuellerSeb
Copy link
Member Author

Also cython_lint fails to read these files.

@MuellerSeb
Copy link
Member Author

scikit learn has also solved this issue, but with an openmp helper module: https://github.com/scikit-learn/scikit-learn/blob/0c72e5448b9da3b0d9202aa5a2abbd9bff4c238a/sklearn/utils/_openmp_helpers.pyx#L25

@MuellerSeb MuellerSeb mentioned this issue Jul 2, 2024
Merged
@LSchueler LSchueler mentioned this issue Jul 4, 2024
Merged
@LSchueler LSchueler self-assigned this Jul 5, 2024
@MuellerSeb
Copy link
Member Author

Solved temporarily by #354

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LSchueler LSchueler

Labels
None yet
Projects
None yet
Milestone
1.6
Development

No branches or pull requests
2 participants
@MuellerSeb @LSchueler