Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Enhancement: Unit selection and max_distance with Variogram where latlon = True #282

Closed
Megil-Zesty opened this issue Nov 7, 2022 · 4 comments · Fixed by #308
Closed
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@Megil-Zesty
Copy link

Megil-Zesty commented Nov 7, 2022

When defining a variogram with latlon=True, I would love to be able to set max_distance directly in gs.vario_estimate() as well as the units for the distance. Then, when plotting the variogram data, I could see semivariance vs distance.

@MuellerSeb
Copy link
Member

Could you provide a code-example? I don't think I fully understand your problem.

@MuellerSeb
Copy link
Member

MuellerSeb commented Jun 12, 2023

#308 solves at least the units issue for the CovModel representation, that can now be defined with the new geo_scale attribute of the CovModel. You can choose between KM_SCALE (earth radius in km as reference), DEGREE_SCALE (length scale in degrees) and RADIAN_SCALE (default, length scale in radians). To use other distance units, you could multiply conversion factors to KM_SCALE, like 1000 * KM_SCALE to have a meter scale.

The vario_estimate routine will always use radians for the great circle distance. To have a better plotting, you could multiply the bin centers with one of the scales given above to have another unit for the x-axis.

For the other problem I assume you mean the remaining arguments of the standard_bins routine, namely bin_no and max_dist that could be forwarded by the vario_estimate routine.
This seems like a useful extension. I will take a look.

@MuellerSeb
Copy link
Member

geo_scale was added to vario_estimate to select the units of the bins with #308

@MuellerSeb
Copy link
Member

Also additional keywords will be forwarded to standard_bins, so this will be solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants