-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: transform submodule; Field storage control; CondSRF optimization #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er; add wrapper; better checks
MuellerSeb
added
enhancement
New feature or request
Refactoring
Code-Refactoring needed here
labels
Aug 1, 2021
…s (reuse pos, meshtype); only recalc krige if needed
MuellerSeb
changed the title
Refactor: transform submodule
Refactor: transform submodule; Field storage control; CondSRF optimization
Aug 3, 2021
@LSchueler this is ready for review. |
LSchueler
requested changes
Aug 6, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow! Awesome!
Just a few minor comments in the code, as usual.
And I fixed a typo and some forgotten "optional" descriptors for the now optional pos
argument. So, don't forget to pull.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #195 #196
gstools.transform
:field
,store
andprocess
keyword to all transformations to control storage and respectnormalizer
apply_function
transformationapply
as wrapper for all transformationstransform
method to allField
(sub)classes as interface totransform.apply
normalizer
submoduleField
:store
keywordpost_process
keyword (apply mean, normalizer, trend)Field["field"]
)set_pos
method to set position tuplepos
tuplepos
,mesh_type
,field_names
,field_shape
,all_fields
propertiesCondSRF
:pos
to underlyingkrige
instancepos
tuple changed (optimized ensemble generation)np.asarray
instead ofnp.array
where possible