Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pyproject.toml #154

Merged
merged 28 commits into from
Apr 7, 2021
Merged

Add pyproject.toml #154

merged 28 commits into from
Apr 7, 2021

Conversation

MuellerSeb
Copy link
Member

@MuellerSeb MuellerSeb commented Apr 6, 2021

This PR adds a pyproject.toml and updates the installation setup.

  • rely on pep517/518 builds for wheels and sdist
  • removed all requirements*.txt files (in setup.cfg now)
  • use setup.cfg for all setup configurations
  • use setup.py only for cython and openmp configurations
  • remove install options for openmp and use an environment variable GSTOOLS_BUILD_PARALLEL (like sklearn) instead
  • use pyproject.toml to define build dependencies, setuptools_scm, coverage and black
  • add format checking stage in CI (using black)
  • update CI script to always use pip and the extras defined in setup.cfg ([test])
  • add .readthedocs.yml to install gstools with pip and [doc] extras on readthedocs
  • updated MANIFEST.in to shrink wheels and sdist (from 45mb to 28mb in the artifacts on GH-Actions)
  • removed development extra [dev] from setup which is equal to pip install gstools[test, doc]

@MuellerSeb MuellerSeb requested a review from LSchueler April 7, 2021 10:33
@MuellerSeb MuellerSeb self-assigned this Apr 7, 2021
@MuellerSeb MuellerSeb added CI/CD Documentation Installation Problems during the installation of GSTools. Refactoring Code-Refactoring needed here labels Apr 7, 2021
@MuellerSeb MuellerSeb added this to the 1.3 milestone Apr 7, 2021
@MuellerSeb MuellerSeb linked an issue Apr 7, 2021 that may be closed by this pull request
Copy link
Member

@LSchueler LSchueler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only had a quick look, but this looks so much cleaner! Approved! ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD Documentation Installation Problems during the installation of GSTools. Refactoring Code-Refactoring needed here
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build dependencies in pyproject.toml
2 participants