-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatic Binning #131
Automatic Binning #131
Conversation
…nd binning should be done automatically
@LSchueler ready for review. 😊 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a really nice convenience addition!
What do you think of moving the _chordal_to_great_circle
method to a more visible place and making it public?
Appart from that, I think we are ready to merge this PR.
I fixes some typos, so don't forget to pull. |
Strange. It was merged, but this PR says it has conflicts and can't be merged. It felt like an internal GitHub Error when I clicked on "merge" and I had to reload the page. Hope nothing was broken. Edit: after closing, it says that it was merged successfully. |
Closes: #55 #36
This PR adds a simple automatic binning routine
standard_bins
to the variogram submodule.It returns an equal division from 0 to
max_dist
withbin_no
as number of bins. The following rules are applied:max_dist
is not given, it is set to one third of the box diameterbin_no
is not given, it is determined by sturges' rule from the number of point combinationsYou can now call
gs.vario_estimate
without passingbin_edges
. In this case, the bin_edges will be determined as described above.