Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isotropic rotation not possible #100

Merged
merged 1 commit into from
Aug 19, 2020
Merged

Isotropic rotation not possible #100

merged 1 commit into from
Aug 19, 2020

Conversation

LSchueler
Copy link
Member

I just wanted to make a pretty plot of a 3d field and instead of rotating the camera, I wanted to simply rotate the field.
This is not possible if the field is isotropic.

Of course, from a stochastic point of view, it doesn't make sense to rotate a field, if it is isotropic. But this is a restriction, which is not necessary, especially if one is working with a single realisation.

Especially for nice plotting, I suggest to simply remove the check for isotropicity, as seen in the diff.

This is an unnecessary check and hinders the ability to quickly rotate
an isotropic field for prettier plots.
@LSchueler LSchueler added the enhancement New feature or request label Aug 14, 2020
@LSchueler LSchueler requested a review from MuellerSeb August 14, 2020 11:42
@LSchueler LSchueler self-assigned this Aug 14, 2020
@LSchueler LSchueler changed the base branch from master to develop August 14, 2020 11:46
Copy link
Member

@MuellerSeb MuellerSeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Freedom to the users. I did this to prevent conversion of structured grids to unstructured in this case.
I still think it's strange, that resulting field is changing when it is set to be isotorpic, but plotting matters!

@MuellerSeb MuellerSeb added this to the 1.3 milestone Aug 18, 2020
@LSchueler
Copy link
Member Author

Thanks for the review!
The problem of converting the grid without rotation will hopefully be a thing of the past with the release of version 2.0!

@LSchueler LSchueler merged commit 67a228d into develop Aug 19, 2020
@MuellerSeb MuellerSeb deleted the isotropic-rotation branch November 11, 2020 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants