Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style changes - padding margin #212

Merged
merged 5 commits into from
Aug 29, 2021
Merged

Conversation

rynzlery
Copy link
Contributor

i made only few CSS changes

Changes :

  • the map editor background icon is not round, the width isn't set as the height is. Maybe the style must be set at the bottom of components ?
  • the play button of map cards has unequal spacings. The margin is set in the variables.scss and I think I checked on all others button that there is no other impacts.
  • the action bar in modals has unequal spacings too
  • I changed the test snapshot to be correct

I absolutely don't know if you want it changed 😄

@netlify
Copy link

netlify bot commented Aug 24, 2021

👷 Deploy request for geoguess2 accepted.

🔨 Explore the source changes: 5ad2c5e

🔍 Inspect the deploy log: https://app.netlify.com/sites/geoguess2/deploys/61256b935ce56d0007f07b8e

@BilelJegham BilelJegham self-assigned this Aug 26, 2021
@codecov
Copy link

codecov bot commented Aug 26, 2021

Codecov Report

Merging #212 (8d40561) into master (00a1d55) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #212   +/-   ##
=======================================
  Coverage   40.44%   40.44%           
=======================================
  Files          38       38           
  Lines        1219     1219           
  Branches      237      237           
=======================================
  Hits          493      493           
  Misses        700      700           
  Partials       26       26           
Impacted Files Coverage Δ
src/components/dialogroom/DialogRoom.vue 66.66% <ø> (ø)
src/components/dialogroom/card/CardRoomName.vue 40.00% <ø> (ø)
...rc/components/dialogroom/card/CardRoomSettings.vue 15.78% <ø> (ø)
src/components/home/SearchBox.vue 69.56% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd4cc02...8d40561. Read the comment docs.

Copy link
Member

@BilelJegham BilelJegham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @rynzlery,

Sorry for the delay.
Thanks for your contribution.

I made a small suggestion if you have time to take a look ;)

src/components/dialogroom/card/CardRoomName.vue Outdated Show resolved Hide resolved
@BilelJegham BilelJegham merged commit aa9da60 into GeoGuess:master Aug 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants