Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branch your source code based on Release info #5224

Closed
Coool opened this issue Aug 21, 2024 · 12 comments
Closed

Branch your source code based on Release info #5224

Coool opened this issue Aug 21, 2024 · 12 comments

Comments

@Coool
Copy link

Coool commented Aug 21, 2024

Hi, @rom1v !

Can you branch your source code with .., v1.23, v1.24, v1.25, v2.0 names and so on based on your tag info from Release section?

Thanks.

@rom1v
Copy link
Collaborator

rom1v commented Aug 21, 2024

From v2.0, there are v2.0-install-release, v2.1-install-release, and so on.

Why it is done that way: #4098 (comment)

From #4098 (comment):

I might consider to move the tag just after the binaries are generated in the future, that would "solve" the problem.

So in the future, v2.7 (for example) might point to the commit with the updated install_release.sh script (and README).

@Coool
Copy link
Author

Coool commented Aug 21, 2024

What does your release cycle issue have to do with to branch your code with names from your already existing Release section according to hash found in specific version. Are you willing to do it or not? After we can talk about your decisions when better to create new release tag. My suggestion after you compiled all your stuff, created all needed checksums and updated all files with new sums you can create new release version. Or it's how you dealing with automatization consequences. Are GitHub actions building your binaries? OK, hope you branch out your repo based on already existing tags.

Thanks.

@rom1v
Copy link
Collaborator

rom1v commented Aug 21, 2024

Sorry, I may have answered too quickly.

Can you branch your source code with .., v1.23, v1.24, v1.25, v2.0 names and so on based on your tag info from Release section?

What does your release cycle issue have to do with to branch your code with names from your already existing Release section according to hash found in specific version.

I think I don't understand what you're requesting exactly.

@Coool
Copy link
Author

Coool commented Aug 21, 2024

How did you created dev branch and other branches on your repo? Same create versions branches. Go under Branch section create new branch with name from Release section and point source to hash from specific version. Or it's impossible!

@Coool
Copy link
Author

Coool commented Aug 21, 2024

How to Create a GIT Branch from a Commit?

@Coool
Copy link
Author

Coool commented Aug 21, 2024

You already have v1.18 version branch with release-v1.18 name. You can in GitHub rename it.

@rom1v
Copy link
Collaborator

rom1v commented Aug 21, 2024

I don't understand what you want (or why). Create your branch locally as you want. Each release has a tag (not a branch), for example v2.6.1.

@Coool
Copy link
Author

Coool commented Aug 21, 2024

I want depend on source author not some bloke like me. It's not hard for me to do on my repo but I'm just some untrusted bloke. This would meet the best coding standards. And tag is not tied with git source code.

@rom1v
Copy link
Collaborator

rom1v commented Aug 21, 2024

This would meet the best coding standards.

Creating a git branch for nothing with no purpose is not "best coding standards".

And tag is not tied with git source code.

Of course it is.

@Coool
Copy link
Author

Coool commented Aug 21, 2024

I'm not Git guru. Everybody have their percpective on things. I'm not arguing. But it's imposible to point to your repo version tags from my repo tags. GitHub only provides poiting to branches. I have other idea will try it then see if it works. Thanks for your input.

P.S.
But what's up with release-v1.18 branch?

@rom1v
Copy link
Collaborator

rom1v commented Aug 21, 2024

But it's imposible to point to your repo version tags from my repo tags.

I don't know about your repo, but here I can select tags (on GitHub, there are two tabs when you select a version: "branches" and "tags"). For example: https://github.com/Genymobile/scrcpy/tree/v2.6.1

But what's up with release-v1.18 branch?

That's a temporary branch when I prepared the release probably, like the hundreds other temporary branches that I never removed. :/

@Coool
Copy link
Author

Coool commented Aug 21, 2024

I stop bothering you with my stupid question. I did my way. Anyway you can't point to remote repo tag when you create new tag or edit existing one, ONLY to remote branches.

Thanks.

@Coool Coool closed this as completed Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants