V2.3.1 install_release.sh calls for wrong scrcpy-server version

[nate2014jatc]

• [ X ] I have read the FAQ.
• [ X ] I have searched in existing issues.

Environment

• OS: Linux Mint
• scrcpy version: 2.3.1
• installation method: Manual Build
• device model: Nothing Phone (1)
• Android version: 13

Describe the bug
Build script calls for incorrect version of pre-built server, leading to client application refusing to start citing that the server and client have a version mismatch.

Prebuilt server URL reads releases/download/v2.3/scrcpy-server-v2.3
instead of releases/download/v2.3.1/scrcpy-server-v2.3.1

Changing this manually leads to a successful build and run.

[rom1v]

Please read explanation in #4098.

You should not execute ./install_release.sh from tag v2.0, but one commit after (in practice, it is intended to be called from current master only).

[nate2014jatc]

That is a very peculiar workflow. I would normally expect the contents of the source archive of a release tag to be able to build that release tag.

I normally build from release tags as the current master (in other projects) tends to be volatile.

[rom1v]

I would normally expect the contents of the source archive of a release tag to be able to build that release tag.

That's the case: you can build the full release with ./release.sh from the tag (or just build for the local host with meson/ninja).

./install_release.sh is a bit peculiar indeed, it has just been added to simplify the installation with a prebuilt server (without building the Android part) instead of following the instructions manually from a documentation file. It is intended to build the latest release on master. I did not want to put it in a separate repo for convenience, but it is not intended to be executed from release tags (for the reasons explained in the linked comment).

It is not ideal, but I don't know how to improve.

[rom1v]

Btw, you can't take any random commit and execute ./install_release.sh either, because the prebuilt server is published for each release only, not for every commit, so the client and the server may be incompatible.