Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resize keeping the right scale #2317

Open
1 task done
albertopasqualetto opened this issue May 15, 2021 · 3 comments
Open
1 task done

Resize keeping the right scale #2317

albertopasqualetto opened this issue May 15, 2021 · 3 comments

Comments

@albertopasqualetto
Copy link
Contributor

albertopasqualetto commented May 15, 2021

Is your feature request related to a problem? Please describe.
When a window resize is performed, it always creates black bars.

Describe the solution you'd like
It would be great if resizing is always keeping the original scale

Describe alternatives you've considered
Instead of double clicking the black bars or using the shortcut

@rom1v
Copy link
Collaborator

rom1v commented May 15, 2021

This is the behavior I initially tried to implement, but at least on X11 (and probably others), it resulted in stuttering and weird blinking. I don't know if the problem is in the backend or in the SDL abstraction, but it did not work well.

Maybe it could work well on Wayland, I haven't tested. If it's the case, it could be implemented as an option.

As a side note, having black bars also allows to click "outside" the device. For example, try a drag&drop starting on the device and drag outside, you can go further 😉 Not sure if it's very useful in practice, but at least it makes the behavior smooth, especially in fullscreen.

@albertopasqualetto
Copy link
Contributor Author

albertopasqualetto commented May 15, 2021 via email

@AndroidDeveloperLB
Copy link

@rom1v Did you have issues on other OSs too?
And what did you try exactly? Maybe you could check out how it's done on other open sourced apps?

BTW, a tip for those who get here:
You can double click the black areas, or use ALT+W , to manually remove the black areas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants