Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mod should be CTRL by default on windows #1654

Closed
1 task done
riexn opened this issue Aug 9, 2020 · 2 comments
Closed
1 task done

Mod should be CTRL by default on windows #1654

riexn opened this issue Aug 9, 2020 · 2 comments

Comments

@riexn
Copy link

riexn commented Aug 9, 2020

Is your feature request related to a problem? Please describe.
As of version 1.5.1, on windows, the shortcuts switched from ctrl+[key] to alt+[key] due to the ability to change the mod key.
It makes sense for Mac since cmd is located where alt is, but in windows the shortcuts are usually ctrl.

This can be quickly solved with

scrcpy --shortcut-mod=lctrl

but, I believe having it the default for windows would be good so it wouldn't confuse new users.

Describe the solution you'd like
By default, mod for windows would be ctrl.

Describe alternatives you've considered
changing the mod key in scrcpy arguments

scrcpy --shortcut-mod=lctrl
@rom1v
Copy link
Collaborator

rom1v commented Aug 9, 2020

The whole point of this change is to forward Ctrl to the device to use it for device shortcuts. For example Ctrl+a to select all text, Ctrl+t to open a new browser tab, etc.

So scrcpy itself must use another key for its own shortcuts.

See #1598 and highlights.

@riexn
Copy link
Author

riexn commented Aug 9, 2020

Makes sense in this case then!

@riexn riexn closed this as completed Aug 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants