Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Install sphinx-gallery in Tests workflow to increase code coverage #1069

Merged
merged 1 commit into from
Mar 16, 2021
Merged

CI: Install sphinx-gallery in Tests workflow to increase code coverage #1069

merged 1 commit into from
Mar 16, 2021

Conversation

seisman
Copy link
Member

@seisman seisman commented Mar 16, 2021 •
edited
Loading

Description of proposed changes

Test pygmt/tests/test_sphinx_gallery.py was skipped because sphinx-gallery is not installed in the Tests workflow.

This PR adds sphinx-gallery in Tests workflow to increase the code coverage.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@seisman seisman marked this pull request as ready for review March 16, 2021 20:37
@seisman seisman added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog labels Mar 16, 2021
@seisman seisman added this to the 0.4.0 milestone Mar 16, 2021
@seisman seisman changed the title CI: Tests need sphinx-gallery for higher code coverage CI: Install sphinx-gallery in Tests workflow to increase code coverage Mar 16, 2021
@seisman seisman requested a review from weiji14 March 16, 2021 20:56
@seisman seisman merged commit 1a2289a into master Mar 16, 2021
@seisman seisman deleted the increase-coverage branch March 16, 2021 21:12
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
@seisman
CI: Install sphinx-gallery in Tests workflow to increase code coverage (
c3bb70f 
GenericMappingTools#1069)

Test pygmt/tests/test_sphinx_gallery.py needs sphinx-gallery to work.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weiji14 weiji14 weiji14 approved these changes

Assignees
No one assigned
Labels
maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Milestone
0.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@seisman @weiji14