Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests fail with xarray 2022.6.0 + numpy 1.20 #2022

Closed
seisman opened this issue Jul 23, 2022 · 2 comments · Fixed by #2057
Closed

Tests fail with xarray 2022.6.0 + numpy 1.20 #2022

seisman opened this issue Jul 23, 2022 · 2 comments · Fixed by #2057
Labels
bug Something isn't working upstream Bug or missing feature of upstream core GMT
Milestone
0.8.0

Comments

@seisman
Copy link
Member

seisman commented Jul 23, 2022

Description of the problem

See the latest test report https://github.com/GenericMappingTools/pygmt/runs/7478048802?check_suite_focus=true.

xarray 2022.6.0 was released on Jul 23, 2022. It seems the new release breaks our tests for Python 3.8.

Let's wait for a few days and see if they have a fix.
@seisman seisman added the bug Something isn't working label Jul 23, 2022
@seisman seisman changed the title Tests fail with Python 3.8 + xarray 2022.6.0 Tests fail with xarray 2022.6.0 + numpy 1.20 Jul 23, 2022
@seisman
Copy link
Member Author

seisman commented Jul 23, 2022

Upstream bug report at pydata/xarray#6818

@weiji14 weiji14 added the upstream Bug or missing feature of upstream core GMT label Jul 23, 2022
@seisman seisman added bug Something isn't working and removed bug Something isn't working labels Jul 24, 2022
@seisman seisman added this to the 0.8.0 milestone Jul 24, 2022
@weiji14 weiji14 linked a pull request Aug 17, 2022 that will close this issue
NEP29: Test PyGMT on NumPy 1.23 and 1.21 #2057
Merged
6 tasks
@weiji14
Copy link
Member

weiji14 commented Aug 17, 2022 •
edited
Loading

Xarray has patched this in pydata/xarray#6821, but it will be a while before an xarray 2022.8.0 or 2022.9.0 release is made that contains this patch, we've workaround this in PyGMT by setting the CI Tests to run on NumPy 1.21 instead of NumPy 1.20 in #2057.

@weiji14 weiji14 closed this as completed Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working upstream Bug or missing feature of upstream core GMT
Projects
None yet
Milestone
0.8.0
Development

Successfully merging a pull request may close this issue.

NEP29: Test PyGMT on NumPy 1.23 and 1.21 GenericMappingTools/pygmt
2 participants
@seisman @weiji14