Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrap blockmean and blockmode #1091

Closed
maxrjones opened this issue Mar 21, 2021 · 2 comments
Closed

Wrap blockmean and blockmode #1091

maxrjones opened this issue Mar 21, 2021 · 2 comments
Labels
eswn-workshop Good issues for first-contributions during the ESWN-PyGMT workshop feature request New feature wanted good first issue Good for newcomers
Milestone
0.5.0

Comments

@maxrjones
Copy link
Member

Description of the desired feature

Wrap blockmean and blockmode. As @weiji14 mentioned previously, much of blockmedian can be moved to a generic _blockm* function which can be used for all three block average estimation methods.

Are you willing to help implement and maintain this feature? Yes- will submit a PR with blockmean for discussion.
@maxrjones maxrjones added the feature request New feature wanted label Mar 21, 2021
@maxrjones maxrjones mentioned this issue Mar 21, 2021
Merged
5 tasks
@maxrjones maxrjones self-assigned this Mar 23, 2021
@weiji14 weiji14 mentioned this issue Mar 23, 2021
Closed
@core-man core-man assigned core-man and unassigned core-man Mar 24, 2021
@weiji14 weiji14 added good first issue Good for newcomers scipy-sprint Things to work on during the SciPy sprint! labels May 26, 2021
@maxrjones maxrjones removed their assignment May 26, 2021
@maxrjones maxrjones added the help wanted Helping hands are appreciated label May 26, 2021
@maxrjones maxrjones added eswn-workshop Good issues for first-contributions during the ESWN-PyGMT workshop and removed scipy-sprint Things to work on during the SciPy sprint! labels Aug 1, 2021
@maxrjones
Copy link
Member Author

Assigning this issue to @arleaman in the ESWN/PyGMT workshop

@arleaman arleaman mentioned this issue Aug 19, 2021
Merged
5 tasks
@seisman
Copy link
Member

seisman commented Sep 15, 2021

The two modules have been wrapped in #1456 and #1092. Closing the issue.

@seisman seisman closed this as completed Sep 15, 2021
@seisman seisman added this to the 0.5.0 milestone Sep 15, 2021
@seisman seisman removed the help wanted Helping hands are appreciated label Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
eswn-workshop Good issues for first-contributions during the ESWN-PyGMT workshop feature request New feature wanted good first issue Good for newcomers
Projects
None yet
Milestone
0.5.0
Development

No branches or pull requests
4 participants
@seisman @maxrjones @weiji14 @core-man