Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation search not working in dev branch #5039

Closed
KristofKoch opened this issue Mar 25, 2021 · 6 comments · Fixed by #5072 or #7364
Closed

Documentation search not working in dev branch #5039

KristofKoch opened this issue Mar 25, 2021 · 6 comments · Fixed by #5072 or #7364
Assignees
@maxrjones
Labels
bug Something isn't working
Milestone
6.2.0

Comments

@KristofKoch
Copy link
Contributor

Not sure if correct place for this but when using the search box in the documentation I get no results when searching in "dev" branch.

"latest" works:
https://docs.generic-mapping-tools.org/latest/search.html?q=plot&check_keywords=yes&area=default#

"dev" doesn't work:
https://docs.generic-mapping-tools.org/dev/search.html?q=plot&check_keywords=yes&area=default#
@maxrjones
Copy link
Member

Thanks for pointing this out, @KristofKoch! We need to update the sphinx_rtd_theme in the gmt repo to fix this, so I will move this issue over to gmt.

@maxrjones maxrjones transferred this issue from GenericMappingTools/website Mar 30, 2021
@maxrjones maxrjones added the bug Something isn't working label Mar 30, 2021
@maxrjones
Copy link
Member

The source distribution for the sphinx_rtd_theme includes many more files than are included in https://github.com/GenericMappingTools/gmt/tree/master/doc/rst/themes/rtd. It seems to me that I can just update the files that are already included in the GMT repository and were changed between v0.5.0 and v0.5.1 (readthedocs/sphinx_rtd_theme@0.5.0...0.5.1). @seisman, does this solution seem good to you based on your experience with updating sphinx_rtd_theme in #3797?

@maxrjones maxrjones self-assigned this Mar 31, 2021
@seisman
Copy link
Member

seisman commented Mar 31, 2021

The source distribution for the sphinx_rtd_theme includes many more files than are included in https://github.com/GenericMappingTools/gmt/tree/master/doc/rst/themes/rtd. It seems to me that I can just update the files that are already included in the GMT repository and were changed between v0.5.0 and v0.5.1 (readthedocs/[email protected]). @seisman, does this solution seem good to you based on your experience with updating sphinx_rtd_theme in #3797?

Yes to me

@maxrjones maxrjones added this to the 6.2.0 milestone Apr 1, 2021
@maxrjones maxrjones mentioned this issue Apr 1, 2021
Merged
4 tasks
@KristofKoch
Copy link
Contributor Author

Time to re-open this one …

Problem is the same as two years ago:

When using the search box in the documentation I get no results when searching in "dev" branch.

"latest" works:
https://docs.generic-mapping-tools.org/latest/search.html?q=plot&check_keywords=yes&area=default#

"dev" doesn't work:
https://docs.generic-mapping-tools.org/dev/search.html?q=plot&check_keywords=yes&area=default#

@KristofKoch KristofKoch reopened this Mar 22, 2023
@maxrjones
Copy link
Member

Probably need another sphinx_rtd_theme update. I'll take a look over the weekend

@seisman
Copy link
Member

seisman commented Mar 30, 2023

Related to readthedocs/sphinx_rtd_theme#1451.

This was referenced Apr 7, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maxrjones maxrjones

Labels
bug Something isn't working
Projects
None yet
Milestone
6.2.0
3 participants
@seisman @maxrjones @KristofKoch