From c328ddd2e5aafce273a1f8cd17e265682038b7b0 Mon Sep 17 00:00:00 2001 From: Ryan Faerman Date: Thu, 26 Jun 2014 17:03:38 -0400 Subject: [PATCH 1/2] Add an absolutely_all shorthand method Using a method with several "magic" attributes is very obtuse for consumers of the gem. Now, instead of executing `.all(nil, {}, true)` the following can be executed: `.absolutely_all`. The latter provides more clarity. --- lib/pipedrive/base.rb | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/lib/pipedrive/base.rb b/lib/pipedrive/base.rb index 9a0adb0..fde1c6a 100644 --- a/lib/pipedrive/base.rb +++ b/lib/pipedrive/base.rb @@ -98,6 +98,10 @@ def all(response = nil, options={},get_absolutely_all=false) end end + def absolutely_all(options = {}) + self.all(nil, options, true) + end + def create( opts = {} ) res = post resource_path, :body => opts if res.success? From 750d9d679f86456af99d9f0da18247a1440fe38b Mon Sep 17 00:00:00 2001 From: Ryan Faerman Date: Thu, 26 Jun 2014 17:06:46 -0400 Subject: [PATCH 2/2] Bump gem version This is a separate commit so it can be excluded during merging if desired by the original maintainers. --- pipedrive-ruby.gemspec | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pipedrive-ruby.gemspec b/pipedrive-ruby.gemspec index 3e36011..d0afdfa 100644 --- a/pipedrive-ruby.gemspec +++ b/pipedrive-ruby.gemspec @@ -5,11 +5,11 @@ Gem::Specification.new do |s| s.name = "pipedrive-ruby" - s.version = "0.3.3" + s.version = "0.3.4" s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version= - s.authors = ["Jan Schwenzien", "Waldemar Kusnezow", "Joel Courtney"] - s.date = "2014-04-23" + s.authors = ["Jan Schwenzien", "Waldemar Kusnezow", "Joel Courtney", "Ryan Faerman"] + s.date = "2014-06-26" s.description = "Ruby wrapper for the Pipedrive API" s.email = "jan@general-scripting.com" s.extra_rdoc_files = [