Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature - Add support for ChromeDriverManager #3

Open
karlgunst opened this issue Oct 11, 2021 · 1 comment
Open

Feature - Add support for ChromeDriverManager #3

karlgunst opened this issue Oct 11, 2021 · 1 comment
Assignees
@karlgunst @abnoviello23

Comments

@karlgunst
Copy link
Contributor

@abnoviello23

Our scraper current allows for the caller to use their own driver or use the static driver

We want to replace the static driver to use ChromeDriverManager (see working in example/app.py)

The user must still be allowed to pass their own driver in as shown below

GoogleNewsScraper(my_driver)

If there is no driver passed in, we want to use ChromeDriverManager to install the latest version of the chrome driver
@abnoviello23
Copy link
Collaborator

@karlgunst I just got the ChromeDriverManager working - it's actually a lot easier than trying to have the driver set up yourself!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@karlgunst karlgunst

@abnoviello23 abnoviello23

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@karlgunst @abnoviello23