Allow null block inside InputGroup Component #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andersr
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the following snippet:
Results in this error:
InputGroup.getIconProps InputGroup.js:105 InputGroup.renderChildren InputGroup.js:171 InputGroup.render InputGroup.js:236 <unknown> ReactCompositeComponent.js:793 measureLifeCyclePerf ReactCompositeComponent.js:74 ReactCompositeComponentWrapper._renderValidatedComponentWithoutOwnerOrContext ReactCompositeComponent.js:792 ReactCompositeComponentWrapper._renderValidatedComponent ReactCompositeComponent.js:819 ReactCompositeComponentWrapper.performInitialMount ReactCompositeComponent.js:361 ReactCompositeComponentWrapper.mountComponent ReactCompositeComponent.js:257 Object.mountComponent ReactReconciler.js:47This update allows for inserting a null value inside the InputGroup block, making something like the following possible:
It appears that this update also addresses #137