Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MFMailComposeViewController is not dismissed after user sent, saved, or canceled the mail. #23

Open
ccmjz opened this issue Jun 6, 2017 · 2 comments

Comments

@ccmjz
Copy link

ccmjz commented Jun 6, 2017

After I shaken the phone to send the report, I find I'm trapped in the mail screen. I'd like to go back to the APP and continue what I was doing. But currently I have to kill the APP to quit the mail view.

I checked the code a little bit, it seems that CLUMailDelegate doesn't dismiss the mailComposeController in mailComposeController(_:didFinishWith:error:). I am not sure if it's by design or not. But by adding [controller dismissViewControllerAnimated:YES completion:nil]; after the switch solved my issue. Could you kindly fix this issue on your side? Or I can open a PR with my fix if you need. Thanks!

@Geek-1001
Copy link
Owner

Hello, @ccmjz !

Thank you so much for your report and sorry for my late reply!
I'll take a look at this issue closer on the next week and write you my results back.

Thanks!
Ahmed.

@ccmjz
Copy link
Author

ccmjz commented Aug 11, 2017

Hi @Geek-1001 ! How is going these days? As you might noticed, I created a PR related to this issue. Let me know if you need me to change anything. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants