Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Great work - almost there... small enhancements #24

Open
sfrechette opened this issue Apr 8, 2012 · 2 comments
Open

Great work - almost there... small enhancements #24

sfrechette opened this issue Apr 8, 2012 · 2 comments

Comments

@sfrechette
Copy link
Member

I have merged the latest changes - deployed locally...
here is what we need to complete before we push live:

-Please do not make any changes to the UI for now - all nice and good (will make new changes once we clear all issues)
-English and French links OK, but would also like to see Facebook and Twitter button be localized when switching languages
-About Box/A Propos content should also be localized...

Once we have these addressed will push and we should consider these final changes as the last code base before we move to version 2.0

@plalx
Copy link
Contributor

plalx commented Apr 8, 2012

Pour avoir un message anglais/francais dans la boîte à propos, tu peux simplement ajouter un label dans les fichiers de langues et ensuite mettre un élément dans le div de la boîte qui ressemble à <p data-label="aboutContent"></p>

@sfrechette
Copy link
Member Author

OK localized About/A propos box done...
Will work on Facebook and Twitter button next

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants