Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Open Street Map #561

Closed
6 tasks
Tracked by #557
mauteri opened this issue Feb 23, 2024 · 12 comments · Fixed by #643
Closed
6 tasks
Tracked by #557

Implement Open Street Map #561

mauteri opened this issue Feb 23, 2024 · 12 comments · Fixed by #643
Assignees
Labels
Milestone

Comments

@mauteri
Copy link
Contributor

mauteri commented Feb 23, 2024

Based on discussion on February 23, this ticket is to

  1. Deprecate Google Maps
  2. Implement Open Street Map

Deliverables

last updated June 15

  • Smooth rendering of an address on the front-end (via OSM)
  • Test layout visibility on desktop + mobile (responsive)
  • Add new meta field for lat-long
  • Added requirement: UPON Saving a venue then resolve the venue addresses to lat-long values via OpenStreet Maps in meta.
  • Test toggle between Google Maps + Ensure no breakage of Google Maps
  • Update the readme file (upon merge)
@MervinHernandez MervinHernandez changed the title uses Google Maps by default, which could be a problem in the EU Implement Open Street Map Feb 23, 2024
@MervinHernandez MervinHernandez moved this to Next Release in GatherPress Project Feb 23, 2024
@jesusyesares
Copy link

Hi, have you considered the possibility of implementing Leaflet.js? It has Open Street Map and other base maps, and It could add other possibilities.

;)

@patriciabt
Copy link
Collaborator

Thank you @jesusyesares
(for @mauteri, Jesús is THE map expert)

@mauteri
Copy link
Contributor Author

mauteri commented Feb 27, 2024

I'm open to this! 😊

@jesusyesares
Copy link

Not so much, I was the map expert in a moment of the history. Now I'm only learning. But I have explored some map projects and leaflet it's the more flexible probably. Map Libre would be another option too.

@pbrocks
Copy link
Collaborator

pbrocks commented Feb 29, 2024

@jesusyesares TBH, I had actually explored Leaflet and Mapbox as potential solutions when initially implementing the maps feature. My recollection for passing on it at the time was that it required some decision-making for settings that were beyond the core features of GatherPress at the time. Happy to revisit and implement if reasonable enough to do so.

@mauteri
Copy link
Contributor Author

mauteri commented Feb 29, 2024

@pbrocks let's discuss Friday, thx Paul!

@stephenerdelyi
Copy link
Collaborator

Hi all, just put in a working PR for this - @jmarx and I are working on the implementation and look forward to sharing updates in our upcoming meeting #643

@carstingaxion carstingaxion added this to the 0.30.0 milestone Jun 13, 2024
@mauteri mauteri moved this from Next Release to In Progress in GatherPress Project Jun 13, 2024
@MervinHernandez
Copy link
Collaborator

🚩 June 15 Review

✅ Updated the objectives for this ticket
✅ Discussed front-end leaflet

  • Added requirement = UPON Saving a venue then resolve the venue addresses to lat-long values via OpenStreet Maps in meta.
  • Steve is working on it as we speak // Expected EOD milestone

@stephenerdelyi
Copy link
Collaborator

Just noting we're in the final stages of this task. Polishing up / fixing small bugs as we find them.

@MervinHernandez
Copy link
Collaborator

🚩 June 22 Review

Acknowledged this is in flgith.

@MervinHernandez
Copy link
Collaborator

@carstingaxion @jmarx where are we gathering the latest code for this feature, which I can review/test?

@mauteri mauteri assigned jmarx and unassigned linusx and pbrocks Jul 14, 2024
@carstingaxion
Copy link
Collaborator

@MervinHernandez where are we gathering the latest code for this feature, which I can review/test?

It's over here: #643

@github-project-automation github-project-automation bot moved this from In Progress to Done in GatherPress Project Jul 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging a pull request may close this issue.

9 participants