Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove linked-in ABC #975

Closed
atomb opened this issue Dec 14, 2020 · 2 comments · Fixed by #1320
Closed

Remove linked-in ABC #975

atomb opened this issue Dec 14, 2020 · 2 comments · Fixed by #1320
Assignees
Labels
tech debt Issues that document or involve technical debt
Milestone

Comments

@atomb
Copy link
Contributor

atomb commented Dec 14, 2020

Once #562 is implemented, but as part of a later release, we should remove the linked-in version of ABC to avoid some of the build issues and crashes that it has led to. This would resolve issues #156, and #233.

@atomb atomb added the tech debt Issues that document or involve technical debt label Dec 14, 2020
@atomb atomb self-assigned this Dec 14, 2020
@atomb atomb added this to the 0.8 milestone Jan 15, 2021
@atomb
Copy link
Contributor Author

atomb commented Apr 16, 2021

My current plan is to finish adding alternatives to all SAW commands based on the linked-in ABC but then do the actual removal of ABC from the build process after the 0.8 release. That way 0.8 will include both the linked-in and external-process versions so they can readily be compared to provide input into improvements needed before 0.9.

@atomb atomb modified the milestones: 0.8, 0.9 Apr 16, 2021
@atomb
Copy link
Contributor Author

atomb commented Jun 15, 2021

PR #1320 implements most of the abcBridge-based commands with pure Haskell code (the exception being cec, which we haven't yet implemented but could). Merging that PR will close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech debt Issues that document or involve technical debt
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant