Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add saw-remote-api tests to CI #962

Closed
pnwamk opened this issue Dec 8, 2020 · 2 comments
Closed

Add saw-remote-api tests to CI #962

pnwamk opened this issue Dec 8, 2020 · 2 comments
Assignees
Labels
subsystem: saw-remote-api Issues related to the SAW server and its RPC bindings tooling: CI Issues involving CI/CD scripts or processes
Milestone

Comments

@pnwamk
Copy link
Contributor

pnwamk commented Dec 8, 2020

to avoid bitrot and the like.

To that end, we recently we missed an update to a SAW record (I'll make a PR for it soon(TM)):

commit d4a6f8b5a855c647563dce25c7ab82787f90555f (master)
Author: Andrew Kent <[email protected]>
Date:   Tue Dec 8 12:46:16 2020 -0800

    Fix missing record field error in SAWServer.

diff --git a/saw-remote-api/src/SAWServer.hs b/saw-remote-api/src/SAWServer.hs
index f6c98ecf..7bb622dc 100644
--- a/saw-remote-api/src/SAWServer.hs
+++ b/saw-remote-api/src/SAWServer.hs
@@ -187,6 +187,7 @@ initialState readFile =
 #else
                 , roProxy = AIGProxy AIG.basicProxy
 #endif
+                , roBasicSS = ss
                 }
          rw = TopLevelRW
                 { rwValues = mempty
@pnwamk pnwamk added the tooling: test infrastructure Issues involving test infrastructure or test execution, or making SAW more testable label Dec 8, 2020
@pnwamk pnwamk self-assigned this Dec 8, 2020
@atomb atomb modified the milestones: 0.7, 0.8 Dec 11, 2020
@atomb
Copy link
Contributor

atomb commented Dec 15, 2020

For some additional context, the tests currently do run in CI, but they're allowed to fail since there's a bunch more work we need to do to set up the environment for them to work correctly.

@pnwamk pnwamk added the subsystem: saw-remote-api Issues related to the SAW server and its RPC bindings label Jan 21, 2021
@pnwamk
Copy link
Contributor Author

pnwamk commented Mar 25, 2021

Fixed - servers are now tested in CI. See #1118

@pnwamk pnwamk closed this as completed Mar 25, 2021
@sauclovian-g sauclovian-g added tooling: CI Issues involving CI/CD scripts or processes and removed tooling: test infrastructure Issues involving test infrastructure or test execution, or making SAW more testable labels Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
subsystem: saw-remote-api Issues related to the SAW server and its RPC bindings tooling: CI Issues involving CI/CD scripts or processes
Projects
None yet
Development

No branches or pull requests

3 participants