Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possibly redundant saw-script Dockerfile in s2nTests #1747

Open
RyanGlScott opened this issue Oct 3, 2022 · 1 comment
Open

Possibly redundant saw-script Dockerfile in s2nTests #1747

RyanGlScott opened this issue Oct 3, 2022 · 1 comment
Labels
tech debt Issues that document or involve technical debt tooling: build system Issues involving SAW's build system tooling: CI Issues involving CI/CD scripts or processes tooling: release engineering Issues involving releases, release processes, or other release engineering concerns
Milestone
2024T3

Comments

@RyanGlScott
Copy link
Contributor

The main Dockerfile used for SAW nightly builds is saw/Dockerfile. However, there is a separate s2nTests/docker/saw.dockerfile that contains nearly the same contents as saw/Dockerfile. To my knowledge, this file is redundant, as it doesn't appear to be used by anything in the CI. If this really is redundant, we should remove it. Otherwise, we should try to replace it with saw/Dockerfile to avoid duplicate work.
@RyanGlScott RyanGlScott added the tooling: CI Issues involving CI/CD scripts or processes label Oct 3, 2022
@RyanGlScott RyanGlScott mentioned this issue Oct 10, 2022
Merged
@chameco
Copy link
Contributor

chameco commented Oct 16, 2022

I believe this file is redundant, and I'm not sure why it was introduced in the first place. Currently, it's referenced by the Makefile in s2nTests for the purpose of building a saw binary that is compatible with the Ubuntu version used by the s2n / awslc / blst containers from the local source tree. saw/Dockerfile, unmodified, appears to serve equally well for this purpose, so I think we can safely remove s2nTests/docker/saw.dockerfile.

@sauclovian-g sauclovian-g added tech debt Issues that document or involve technical debt tooling: build system Issues involving SAW's build system tooling: release engineering Issues involving releases, release processes, or other release engineering concerns labels Nov 5, 2024
@sauclovian-g sauclovian-g added this to the 2024T3 milestone Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tech debt Issues that document or involve technical debt tooling: build system Issues involving SAW's build system tooling: CI Issues involving CI/CD scripts or processes tooling: release engineering Issues involving releases, release processes, or other release engineering concerns
Projects
None yet
Milestone
2024T3
Development

No branches or pull requests
3 participants
@chameco @RyanGlScott @sauclovian-g