Non-exhaustive pattern matches in heapster-saw

[brianhuffman]

We should fix this warning:

heapster-saw       > [ 6 of 19] Compiling Verifier.SAW.Heapster.Permissions
heapster-saw       >
heapster-saw       > /Users/huffman/Work/saw-script/heapster-saw/src/Verifier/SAW/Heapster/Permissions.hs:4810:5: warning: [-Wincomplete-patterns]
heapster-saw       >     Pattern match(es) are non-exhaustive
heapster-saw       >     In an equation for ‘go’:
heapster-saw       >         Patterns not matched:
heapster-saw       >             (PExpr_Var _) []
heapster-saw       >             (PExpr_Var _) (_:_)
heapster-saw       >             (PExpr_BV _ _) []
heapster-saw       >             (PExpr_BV _ _) (_:_)
heapster-saw       >      |
heapster-saw       > 4810 |     go off borrows
heapster-saw       >      |     ^^^^^^^^^^^^^^...

saw-script/heapster-saw/src/Verifier/SAW/Heapster/Permissions.hs

Lines 4810 to 4814 in 2b0b46b

	go off borrows
	| bvLeq end off
	= True
	| Just i <- findIndex (permForOff off) borrows
	= go (bvAdd off (bvRangeLength (borrows!!i))) (deleteNth i borrows)

For any "impossible" cases, we should add calls to panic. I also see that the same file contains many uses of the error function; those should be replaced by panic as appropriate.

[eddywestbrook]

Yes, I have noticed this non-exhaustive case as well, and have fixed it in the branch I am currently working on. I can change the error calls to panic in a later change, after this one that I'm currently working on.

[RyanGlScott]

This warning appears to have been fixed in the master branch.