Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filepath printing results in golden test failures #764

Closed
hazelweakly opened this issue Jun 10, 2020 · 1 comment
Closed

Filepath printing results in golden test failures #764

hazelweakly opened this issue Jun 10, 2020 · 1 comment
Labels
maybe-fixed Might be resolved, but this needs to be confirmed. test-framework For issues related to Cryptol's test framework.

Comments

@hazelweakly
Copy link
Contributor

hazelweakly commented Jun 10, 2020

In the introduction of #756, we added a golden test that validates that cryptol sends the right error message when attempting to include malformed utf8. The error message includes a path, which is os dependent, so on posix file systems the golden test works, but on windows it fails with

    T14.icry: [Failed]
115
3c3
116
< Parse error at ./T14/Main.cry:3:9,
117
---
118
> Parse error at .\T14\Main.cry:3:9,
119

(note unix vs win style path printing)

We have a few potential solutions for this, all with various trade-offs. It's worth noting that our golden test-runner currently doesn't have any facilities for os-specific tests or environmentally-aware contextual execution of files.

@robdockins robdockins added the test-framework For issues related to Cryptol's test framework. label Jun 19, 2020
@brianhuffman brianhuffman added the maybe-fixed Might be resolved, but this needs to be confirmed. label Jul 16, 2021
@brianhuffman
Copy link
Contributor

@yav, did you fix this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maybe-fixed Might be resolved, but this needs to be confirmed. test-framework For issues related to Cryptol's test framework.
Projects
None yet
Development

No branches or pull requests

3 participants