Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase typechecking performance for Cryptol::Extras #302

Closed
acfoltzer opened this issue Jan 19, 2016 · 3 comments
Closed

Increase typechecking performance for Cryptol::Extras #302

acfoltzer opened this issue Jan 19, 2016 · 3 comments
Labels
feature request Asking for new or improved functionality typechecker Issues related to type-checking Cryptol code.
Milestone

Comments

@acfoltzer
Copy link
Contributor

The definitions added in #299 wound up split out into the Cryptol::Extras module due to the performance regression they introduced (speed of typechecking the Prelude is of very high priority because it happens so often). Let's work on improving performance of the typechecker further, and then merge these definitions back into the regular Prelude. (cc @TomMD)

@acfoltzer acfoltzer added the feature request Asking for new or improved functionality label Jan 19, 2016
@acfoltzer acfoltzer added this to the Someday milestone Jan 19, 2016
@TomMD
Copy link
Contributor

TomMD commented Jan 20, 2016

The Cryptol::Extras module can not be imported without something like CRYPTOLPATH=$repo/lib. Is it easy to add the Extras module to wherever the prelude is installed so its in scope? Once that's done I'll add extras as an import to Minilock/* so it loads properly.

@TomMD
Copy link
Contributor

TomMD commented Jan 20, 2016

@acfoltzer mentioned to me that the bindist should locate Cryptol::Extras fine and the issue is probably limited to cabal-install users. @elliottt, I think adding Extras.cry to Cryptol/Prelude.hs would fix the issue - thoughts?

@acfoltzer acfoltzer added the typechecker Issues related to type-checking Cryptol code. label Jun 29, 2016
@atomb
Copy link
Contributor

atomb commented Jun 22, 2017

Type checking Cryptol::Extras is now pretty quick. It seems to take about 0.05s on my machine (comparing the load time of cryptol with no arguments to running it on a file containing only import Cryptol::Extras).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Asking for new or improved functionality typechecker Issues related to type-checking Cryptol code.
Projects
None yet
Development

No branches or pull requests

3 participants