From 5c3cdffa4f535f5bc1ca8157af5eb6bbef65e9be Mon Sep 17 00:00:00 2001
From: Aaron Tomb <atomb@galois.com>
Date: Mon, 26 Jul 2021 09:40:44 -0700
Subject: [PATCH] Improve CI for Windows and portable Docker container (#1248)

* Disable Windows RPC tests

They seem to hang instead of failing at the moment, so until we get them
working it seems like it's better to just leave them out.

* Attempt to make "portability" build only run nightly.
---
 .github/workflows/ci.yml | 25 ++++++++++++-------------
 1 file changed, 12 insertions(+), 13 deletions(-)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 7b7172929..1c7d861ec 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -196,15 +196,13 @@ jobs:
           path: bin
           name: ${{ runner.os }}-bin
 
-# This is commented out because it appears to fail uploading
-# and the entire build fails.  XXX: investigate why.
-#      - uses: actions/upload-artifact@v2
-#        if: runner.os == 'Windows'
-#        with:
-#          name: ${{ env.NAME }}
-#          path: "cryptol.msi*"
-#          if-no-files-found: error
-#          retention-days: ${{ needs.config.outputs.retention-days }}
+      - uses: actions/upload-artifact@v2
+        if: runner.os == 'Windows'
+        with:
+          name: ${{ env.NAME }}
+          path: "cryptol.msi*"
+          if-no-files-found: error
+          retention-days: ${{ needs.config.outputs.retention-days }}
 
   test:
     runs-on: ${{ matrix.os }}
@@ -296,10 +294,11 @@ jobs:
             file: Dockerfile
             image: ghcr.io/galoisinc/cryptol
             cache: ghcr.io/galoisinc/cache-cryptol
-#          - build-args: PORTABILITY=true
-#            file: cryptol-remote-api/Dockerfile
-#            image: ghcr.io/galoisinc/cryptol-remote-api
-#            cache: ghcr.io/galoisinc/cache-cryptol-remote-api
+          - build-args: PORTABILITY=true
+            file: cryptol-remote-api/Dockerfile
+            image: ghcr.io/galoisinc/cryptol-remote-api
+            cache: ghcr.io/galoisinc/cache-cryptol-remote-api
+            if: ${{ github.event_name == 'schedule' }}
           - build-args: PORTABILITY=false
             file: cryptol-remote-api/Dockerfile
             image: ghcr.io/galoisinc/cryptol-remote-api