I would like help with FreeBSD ports

[Martinfx]

Hi,
I want help with porting gaffer to FreeBSD. I have qt5 installed but scons cannot find qt headers.
I cannot find some QT_PATH for scons_args in SConstruct
https://github.com/Martinfx/FreeBSD-Ports/pull/174/files

file /usr/home/maxfx/Documents/FreeBSD-Ports/gaffer/work/gaffer-1.5.1.0/SConstruct,line 716:
        Configure(confdir = .sconf_temp)
scons: Configure: Checking for Inkscape... 
scons: Configure: (cached) yes

scons: Configure: Checking for Sphinx...
scons: Configure: (cached) yes

scons: Configure: Checking for Qt...
.sconf_temp/conftest_731c39a501e4419ece6181da209afcc8_0.cpp <-
  |
  |     #include <iostream>
  |     #include "QtCore/qconfig.h"
  |
  |     int main()
  |     {
  |#ifdef QT_VERSION_MAJOR
  |             std::cout << QT_VERSION_MAJOR;
  |#else
  |             std::cout << 4;
  |#endif
  |             return 0;
  |     }
  |     
c++ -o .sconf_temp/conftest_731c39a501e4419ece6181da209afcc8_0.o -c "-O2 -pipe -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing -isystem /usr/local/include " -isystem /usr/home/maxfx/Documents/FreeBSD-Ports/gaffer/work/gaffer-1.5.1.0/build/gaffer-1.5.1.0-linux/include -isystem /usr/home/maxfx/Documents/FreeBSD-Ports/gaffer/work/gaffer-1.5.1.0/build/gaffer-1.5.1.0-linux/include/Imath -isystem /usr/home/maxfx/Documents/FreeBSD-Ports/gaffer/work/gaffer-1.5.1.0/build/gaffer-1.5.1.0-linux/include/GL -std=c++17 -fvisibility=hidden -DNDEBUG -DBOOST_DISABLE_ASSERTS -O3 -Werror -DBOOST_FILESYSTEM_VERSION=3 -DBOOST_FILESYSTEM_NO_DEPRECATED -Iinclude .sconf_temp/conftest_731c39a501e4419ece6181da209afcc8_0.cpp
.sconf_temp/conftest_731c39a501e4419ece6181da209afcc8_0.cpp:3:11: fatal error: 'QtCore/qconfig.h' file not found
    3 |         #include "QtCore/qconfig.h"
      |                  ^~~~~~~~~~~~~~~~~~
1 error generated.
scons: Configure: no

[johnhaddon]

When we build for linux, we use precompiled binaries for Qt and all our other dependencies (of which there are many). We manage the build and release process for those dependencies at https://github.com/GafferHQ/dependencies. Have you build those for FreeBSD already?

[johnhaddon]

As I said in an earlier answer, it looks like it is in OneTBB still, but now named tbb::detail::atomic_backoff. See https://github.com/uxlfoundation/oneTBB/blob/db883d1d0f6c5a0152fc21f146c06f9c02bb2f88/include/oneapi/tbb/detail/_utils.h#L45

[Martinfx]

As I said in an earlier answer, it looks like it is in OneTBB still, but now named tbb::detail::atomic_backoff. See https://github.com/uxlfoundation/oneTBB/blob/db883d1d0f6c5a0152fc21f146c06f9c02bb2f88/include/oneapi/tbb/detail/_utils.h#L45

yes. there is. thank you.

[Martinfx]

do you think it is broken oneapi ?

In file included from src/Gaffer/ValuePlug.cpp:44:
In file included from include/Gaffer/Process.h:178:
In file included from include/Gaffer/Process.inl:37:
/usr/local/include/oneapi/tbb/concurrent_hash_map.h:840:49: error: call to implicitly-deleted default constructor of 'tbb::detail::d2::concurrent_hash_map<(anonymous namespace)::HashCacheKey, std::vector<boost::intrusive_ptr<Gaffer::Process::TypedCollaboration<Gaffer::ValuePlug::HashProcess>>>>::hash_compare_type' (aka 'tbb::detail::d1::tbb_hash_compare<(anonymous namespace)::HashCacheKey>')
    concurrent_hash_map() : concurrent_hash_map(hash_compare_type()) {}
                                                ^
include/Gaffer/Process.inl:304:116: note: in instantiation of member function 'tbb::detail::d2::concurrent_hash_map<(anonymous namespace)::HashCacheKey, std::vector<boost::intrusive_ptr<Gaffer::Process::TypedCollaboration<Gaffer::ValuePlug::HashProcess>>>>::concurrent_hash_map' requested here
typename Process::TypedCollaboration<ProcessType>::PendingCollaborations Process::TypedCollaboration<ProcessType>::g_pendingCollaborations;
                                                                                                                   ^
include/Gaffer/Process.inl:321:21: note: in instantiation of static data member 'Gaffer::Process::TypedCollaboration<Gaffer::ValuePlug::HashProcess>::g_pendingCollaborations' requested here
        CollaborationType::g_pendingCollaborations.insert( accessor, cacheKey );
                           ^
src/Gaffer/ValuePlug.cpp:286:25: note: in instantiation of function template specialization 'Gaffer::Process::acquireCollaborativeResult<Gaffer::ValuePlug::HashProcess, const Gaffer::ValuePlug *&, const Gaffer::ValuePlug *&, const Gaffer::ComputeNode *&>' requested here
                                                result = Process::acquireCollaborativeResult<HashProcess>( cacheKey, p, plug, computeNode );
                                                                  ^
/usr/local/include/oneapi/tbb/detail/_hash_compare.h:85:20: note: default constructor of 'tbb_hash_compare<(anonymous namespace)::HashCacheKey>' is implicitly deleted because field 'my_hash_func' has a deleted default constructor
    std::hash<Key> my_hash_func;
                   ^
/usr/include/c++/v1/__functional/hash.h:510:36: note: default constructor of 'hash<(anonymous namespace)::HashCacheKey>' is implicitly deleted because base class '__enum_hash<(anonymous namespace)::HashCacheKey>' has a deleted default constructor
struct _LIBCPP_TEMPLATE_VIS hash : public __enum_hash<_Tp> {};
                                   ^
/usr/include/c++/v1/__functional/hash.h:504:3: note: '__enum_hash' has been explicitly marked deleted here
  __enum_hash()                              = delete;
  ^
In file included from src/Gaffer/ValuePlug.cpp:44:
In file included from include/Gaffer/Process.h:178:
In file included from include/Gaffer/Process.inl:37:
In file included from /usr/local/include/oneapi/tbb/concurrent_hash_map.h:26:
/usr/local/include/oneapi/tbb/detail/_hash_compare.h:74:53: error: type 'const std::hash<HashCacheKey>' does not provide a call operator
    std::size_t hash( const Key& a ) const { return my_hash_func(a); }
                                                    ^~~~~~~~~~~~
/usr/local/include/oneapi/tbb/concurrent_hash_map.h:1278:49: note: in instantiation of member function 'tbb::detail::d1::tbb_hash_compare<(anonymous namespace)::HashCacheKey>::hash' requested here
        hashcode_type const h = my_hash_compare.hash( key );
                                                ^
/usr/local/include/oneapi/tbb/concurrent_hash_map.h:1146:16: note: in instantiation of function template specialization 'tbb::detail::d2::concurrent_hash_map<(anonymous namespace)::HashCacheKey, std::vector<boost::intrusive_ptr<Gaffer::Process::TypedCollaboration<Gaffer::ValuePlug::HashProcess>>>>::lookup<true, (anonymous namespace)::HashCacheKey, tbb::detail::d2::concurrent_hash_map<(anonymous namespace)::HashCacheKey, std::vector<boost::intrusive_ptr<Gaffer::Process::TypedCollaboration<Gaffer::ValuePlug::HashProcess>>>>::node *(*)(tbb::detail::d1::tbb_allocator<tbb::detail::d2::hash_map_base<tbb::detail::d1::tbb_allocator<std::pair<const (anonymous namespace)::HashCacheKey, std::vector<boost::intrusive_ptr<Gaffer::Process::TypedCollaboration<Gaffer::ValuePlug::HashProcess>>>>>, tbb::detail::d1::spin_rw_mutex>::bucket> &, const (anonymous namespace)::HashCacheKey &, const std::vector<boost::intrusive_ptr<Gaffer::Process::TypedCollaboration<Gaffer::ValuePlug::HashProcess>>> *)>' requested here
        return lookup</*insert*/true>(key, nullptr, &result, /*write=*/true, &allocate_node_default_construct<>);
               ^
include/Gaffer/Process.inl:321:45: note: in instantiation of member function 'tbb::detail::d2::concurrent_hash_map<(anonymous namespace)::HashCacheKey, std::vector<boost::intrusive_ptr<Gaffer::Process::TypedCollaboration<Gaffer::ValuePlug::HashProcess>>>>::insert' requested here
        CollaborationType::g_pendingCollaborations.insert( accessor, cacheKey );
                                                   ^
src/Gaffer/ValuePlug.cpp:286:25: note: in instantiation of function template specialization 'Gaffer::Process::acquireCollaborativeResult<Gaffer::ValuePlug::HashProcess, const Gaffer::ValuePlug *&, const Gaffer::ValuePlug *&, const Gaffer::ComputeNode *&>' requested here
                                                result = Process::acquireCollaborativeResult<HashProcess>( cacheKey, p, plug, computeNode );
                                                                  ^
2 errors generated.

[Martinfx]

Hi John,

I hope this message finds you well. I wanted to sincerely apologize for not being able to provide the patch for the Gaffer application at this time.

Unfortunately, I’ve been caught up with some other commitments and technical challenges that have delayed my progress. I truly appreciate your patience and understanding, and I will prioritize addressing this as soon as I am able to get back to it.

If there’s anything specific you’d like me to focus on or any additional context that would help with the patch in the meantime, please let me know.

Thank you again for your understanding, and I’m sorry for any inconvenience this may have caused.

[johnhaddon]

No need to apologise!

We'll need to be looking at OneTBB ourselves before too long, so hopefully that will remove some of the hurdles if you have time to come back to this again later...