From c1be2dabb6c85b6ea093e4744e1e9a4eb6667bc0 Mon Sep 17 00:00:00 2001 From: Murray Stevenson <50844517+murraystevenson@users.noreply.github.com> Date: Sat, 16 Nov 2024 11:24:46 +1100 Subject: [PATCH 1/2] CI : Drop GCC9 builds --- .github/workflows/main.yml | 24 +++++------------------- 1 file changed, 5 insertions(+), 19 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 1079d396d95..53579a6c382 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -28,19 +28,18 @@ jobs: # and then use `include` to define their settings. name: [ - linux-gcc9, - linux-debug-gcc9, linux-gcc11, + linux-debug-gcc11, windows, ] include: - - name: linux-gcc9 + - name: linux-gcc11 os: ubuntu-20.04 buildType: RELEASE publish: true - containerImage: ghcr.io/gafferhq/build/build:2.1.2 + containerImage: ghcr.io/gafferhq/build/build:3.0.0 # GitHub container builds run as root. This causes failures for tests that # assert that filesystem permissions are respected, because root doesn't # respect permissions. So we run the final test suite as a dedicated @@ -49,11 +48,11 @@ jobs: sconsCacheMegabytes: 400 jobs: 4 - - name: linux-debug-gcc9 + - name: linux-debug-gcc11 os: ubuntu-20.04 buildType: DEBUG publish: false - containerImage: ghcr.io/gafferhq/build/build:2.1.2 + containerImage: ghcr.io/gafferhq/build/build:3.0.0 testRunner: su testUser -c testArguments: -excludedCategories performance # Debug builds are ludicrously big, so we must use a larger cache @@ -61,19 +60,6 @@ jobs: sconsCacheMegabytes: 2500 jobs: 4 - - name: linux-gcc11 - os: ubuntu-20.04 - buildType: RELEASE - publish: true - containerImage: ghcr.io/gafferhq/build/build:3.0.0 - # GitHub container builds run as root. This causes failures for tests that - # assert that filesystem permissions are respected, because root doesn't - # respect permissions. So we run the final test suite as a dedicated - # test user rather than as root. - testRunner: su testUser -c - sconsCacheMegabytes: 400 - jobs: 4 - - name: windows os: windows-2019 buildType: RELEASE From 7ddf9b1cef4479027993847ca1f29bfeae235db8 Mon Sep 17 00:00:00 2001 From: Murray Stevenson <50844517+murraystevenson@users.noreply.github.com> Date: Sat, 16 Nov 2024 11:26:00 +1100 Subject: [PATCH 2/2] CI : Update to node20 actions --- .github/workflows/main.yml | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 53579a6c382..7930d2f7f63 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -79,16 +79,12 @@ jobs: ARNOLD_FORCE_ABORT_ON_LICENSE_FAIL: 0 # And don't abort because the license isn't found GAFFER_BUILD_DIR: "./build" GAFFER_CACHE_DIR: "./sconsCache" - # GitHub have moved to running actions on Node20, which prevents them from - # running on CentOS 7. The below allows actions to continue running on Node16 - # until October. - ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: true steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 - - uses: ilammy/msvc-dev-cmd@v1.12.1 + - uses: ilammy/msvc-dev-cmd@v1.13.0 with: sdk: 10.0.17763.0 @@ -158,7 +154,7 @@ jobs: if: runner.os == 'Windows' - name: Cache - uses: actions/cache@v3 + uses: actions/cache@v4 with: path: ${{ env.GAFFER_CACHE_DIR }} key: ${{ runner.os }}-${{ matrix.containerImage }}-${{env.GAFFER_DEPENDENCIES_HASH}}-${{ matrix.buildType }}-${{ github.sha }} @@ -245,10 +241,13 @@ jobs: echo "::remove-matcher owner=validateRelease::" if: matrix.publish - - uses: actions/upload-artifact@v3 + - uses: actions/upload-artifact@v4 with: name: ${{ env.GAFFER_BUILD_NAME }} path: ${{ env.GAFFER_BUILD_NAME }}.${{ env.PACKAGE_EXTENSION }} + # Using compression-level 0 avoids compressing our already compressed + # package and results in a significantly faster upload. + compression-level: 0 if: matrix.publish - name: Publish Release