Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails when manifest.json contains comments #115

Open
1 task done
melink14 opened this issue Aug 25, 2024 · 0 comments
Open
1 task done

Fails when manifest.json contains comments #115

melink14 opened this issue Aug 25, 2024 · 0 comments

Comments

@melink14
Copy link

Issue

  • I have searched the issues of this repository and believe that this is not a duplicate.

What you did and problem description

I added a comment to my manifest.json to note some potentially surprising choices. This caused the release to fail due to a JSON parsing error.

Of course, pure JSON doesn't allow comments but since chrome does and this is a chrome specific repo, it seems reasonable.

Suggested solution

It looks like we're using another library for JSON parsing so we'd have to complain upstream or use another library/option to make this work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant