Move server files to typescript #75
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). |
|
Thanks for your contributions! There are some merge conflicts with the develop branch; can you resolve those? |
ML-Chen
reviewed
Sep 14, 2020
| await Mongo(); | ||
|
|
||
| return Nonprofit.distinct("_id") as string[]; | ||
| return await Nonprofit.distinct("_id"); |
There was a problem hiding this comment.
I think as a style guideline, we're not using return await (see https://eslint.org/docs/rules/no-return-await), except in a try/catch block.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consider splitting types.ts into several files.
resolve #68