Separate storyshots #155
Separate storyshots #155
Conversation
| getSnapshotFileName, | ||
| } from '@storybook/addon-storyshots'; | ||
| import renderer from 'react-test-renderer'; | ||
| import 'jest-styled-components'; |
There was a problem hiding this comment.
This library is not working as I expect. Do you know why?
There was a problem hiding this comment.
I am checking the problem XD
Btw, this plugins quite useful in my project.
There was a problem hiding this comment.
sorry, i can't find the problem why it is not working...
There was a problem hiding this comment.
I guess it is related to this. I got some warning about multiple instances of styled-components when I open storybook. It's not a new issue though.
https://github.com/styled-components/jest-styled-components#working-with-multiple-packages
There was a problem hiding this comment.
But I found that there has only one version of styled-components (in native and web packages), are any 3rd party libraries also using the styled-components?
There was a problem hiding this comment.
Yes. Sorry I forget to mention about that.
I have included my own priority nav https://github.com/ericyip/react-priority-navigation
I tried to avoid bundle with sc but it's not working..
There was a problem hiding this comment.
I think you should separate them XD
There was a problem hiding this comment.
Finally got this one working
Add custom serializer in order to work with multiSnapShot
storybookjs/storybook#887 (comment)
| @@ -0,0 +1,3 @@ | |||
| { | |||
| "extends": "../../../.babelrc" | |||
There was a problem hiding this comment.
I thought it will be loaded as default
There was a problem hiding this comment.
By default, Storybook loads your root
.babelrcfile and load those configurations.
https://storybook.js.org/configurations/custom-babel-config/
But it only reads the "root" of web/ workspace, if the babelrc is out of its scope, it wont be loaded.
There was a problem hiding this comment.
Another question, why you moved .babelrc to the root since #144?
There was a problem hiding this comment.
Shhh.. I thought it is duplicated
cjies
force-pushed
the
CJ/fix_web_storybook
branch
from
fd3ded5 to
bba80ea
Compare
.editorconfigto maintain consistent coding styles between different editors.